-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Consolidate DDSQL references #28821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate DDSQL references #28821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Esther! This looks like a gigantic chonk of work; nice job!
I left some minor comments; let me know if you have any questions 🙂 Overall, I think this is a bit of a tough nut to crack if you aren't already familiar with what's happening (what am I saying, I'm clearly talking about myself 😂). The current docs make it sound like the SQL reference is just generic SQL, which makes the new labelling of DDSQL a bit confusing - is it the same SQL someone might learn at another company, or is it now something unique to us? I don't know enough about it to make a call!
I also struggled to understand why the DDSQL Editor content was split between the DDSQL and DDSQL Editor sections in the left nav - I don't understand enough about why they're different, and struggled to intuit why some content would be in one section or the other. I wonder if if renaming DDSQL to DDSQL Reference might help clear that up? Again, I'm not entirely sure what's right based on the problem we're solving here.
Lastly, while I don't think there's anything with the disclaimers you added in this PR, I think the framing is different from what you described in the PR description, so I thought I'd bring it up. The disclaimers frame this distinction as a matter of support, and kind of gloss over the fact that there are two versions of DDSQL - it kind of maybe sounds like the differences are quite minor. Your description here frames it around two versions of DDSQL, which isn't really mentioned in the disclaimers, which also makes the differences sound more significant and important to understand! I think I prefer the explicit "hey, there are two different versions with different support" angle, rather than the "the DDSQL Editor might not support some syntax" angle, if that makes sense?
Again, let me know if you'd like to chat about this more. It seems like a lot to understand, and that can be tough to express in the docs. But you've done a great job so far!
Co-authored-by: Janine Chan <[email protected]>
For the tabs, what do we think about:
I do think that putting 'DDSQL Editor' in tabs might cause more confusion though since DDSQL Editor will have v1 eventually. @jinatdatadog |
- Remove disclaimer from DDSQL Editor Syntax docs - Rephrase disclaimer to be transparent about the two different variants of DDSQL and direct customers to the relevant docs - Rename DDSQL to DDSQL Reference to distinguish between DDSQL Editor - Update URLs for DDSQL Reference - Update tabs to DDSQL Editor Syntax (Preview) and specify DDSQL Editor for all child pages
@TylerMills @jinatdatadog @janine-c As DDSQL Editor begins to adopt the broader syntax, we can revisit the framing to ensure the docs stay intuitive and accurate for customers! |
@estherk15 "As DDSQL Editor begins to adopt the broader syntax, we can revisit the framing to ensure the docs stay intuitive and accurate for customers!" I think the plan is to start exposing this in the next week or so (but will run in parallel with old version) so I think these tabs are still confusing. |
@TylerMills Thanks for the additional context. How long do you plan to run these in parallel and which features are you enabling for customers? Or is it just that customers can either use the DDSQL Editor syntax vs. Workspaces syntax? How are you communicating this to DDSQL Editor users? |
@estherk15 we'll have the appropriate in-app enablement/documentation for DDSQL Editor customers. The plan is to allow them to use both syntax in DDSQL Editor from DASH for ~2 months. After that we'll do a hard cutover where all DDSQL Editor customers are using DDSQL (and not DDSQL Editor Preview Syntax) I can reach out when we do that hard cutover to have the DDSQL Editor Preview Syntax deprecated |
How does the user know which syntax they are using in the app? Do V0 and V1 appear in the app? |
cc @liujuliet I think if we have the tabs simply say: |
@TylerMills @jinatdatadog Thank you for the context and feedback! The tabs are now labeled DDSQL and DDSQL (Preview). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good, Esther! I'm finding it a lot simpler to navigate and understand. My main concern here is with making it clear which syntax version the guides are targeting, but once we've got that cleared up, I think we're ready to 🎉
Co-authored-by: Janine Chan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Most are document files.
Where are the two yaml files used? Have you run this on staging? Maybe try it first (if not yet) to avoid unexpected behavior
|
||
## Supported DDSQL Syntax | ||
|
||
DDSQL is a query language for Datadog data. It implements several standard SQL operations, such as `SELECT`, and allows queries against unstructured data, such as [tags][1]. You can perform actions like getting exactly the data you want by writing your own `SELECT` statement, or querying tags as if they are standard table columns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice description
@@ -219,23 +234,23 @@ SELECT | |||
### `TRIM` | |||
{{< code-block lang="sql" >}} | |||
SELECT | |||
TRIM(name) AS trimmed_name | |||
trim(name) AS trimmed_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Since SQL is not case sensitive, it is find to make this lowercase. However, it is nice to keep them upper case as they are functions/keywords
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, Esther. Thank you for listening to the many voices weighing in on this change. I find the end result very clear, and I think the users will appreciate it!
Left some non-blocking feedback above on the order of menu items.
config/_default/menus/main.en.yaml
Outdated
@@ -1184,7 +1184,7 @@ menu: | |||
pre: cloudcraft | |||
identifier: cloudcraft | |||
parent: essentials_heading | |||
weight: 270000 | |||
weight: 130000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the old 270000 value was intentional to put Cloudcraft at the bottom of the menu. I probably would have left Cloudcraft at 270000. DDSQL Reference could maybe even be above CoScreen and CoTerm, although then you have to make even more changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the Cloudcraft context, moved DDSQL Reference up!
What does this PR do? What is the motivation?
This PR consolidates the DDSQL references for Workspaces and the DDSQL Editor into a single resource page.
DOCS-10588
🧩 Problem this solves:
What to look for during review:
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes